Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

escape closing tags #167

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

escape closing tags #167

wants to merge 5 commits into from

Conversation

jburghardt
Copy link

@jburghardt jburghardt commented Oct 11, 2019

Escapes closing tags

Fixes #165.

@ljharb ljharb mentioned this pull request Oct 11, 2019
@ljharb
Copy link
Collaborator

ljharb commented Oct 11, 2019

It'd be good to add a test specifically for the newline case, if we can.

@jburghardt
Copy link
Author

Thought about that too,
maybe also check for parseable json cause thats where we encountered the error first.

I'll add something by monday

@jburghardt
Copy link
Author

it should now correctly check that </ escapes to '&lt;/.

'loads the escaped content correctly' also checks the json.parse method, which failes without
encoding the </script tag. so this should be covered.

@jburghardt jburghardt requested a review from ljharb October 17, 2019 06:45
@jburghardt
Copy link
Author

review was requested btw

@ljharb
Copy link
Collaborator

ljharb commented Mar 24, 2020

This is ready to go, but tests are failing for an unrelated reason. I'm looking into it.

@ljharb ljharb mentioned this pull request Mar 24, 2020
@ljharb ljharb force-pushed the master branch 5 times, most recently from 25e6e39 to 27cd82a Compare March 24, 2020 23:22
@richter-alex
Copy link

Hey @ljharb - any luck getting the aforementioned tests to pass? Happy to help if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode closing Tag
3 participants